Bash Script Fails to Find Update Specific Line: grep, sed Solutions

Introduction

In this article, we will discuss the challenges faced in a simple Bash script that adds Wayland support options to specific application files, and how to solve these issues using grep and sed commands effectively.

Problem Overview

The problem arises when writing a script that uses grep to check a specific line and sed to add options missing in the files requiring Wayland support. The challenge comes from the inconsistency in the files and the need for a robust solution that can handle these discrepancies.

The Original Script

Let's take a look at the initial script that was causing issues:

 #!/bin/bash

 FILES_PATH="/path/to/application/files"

 for file in "$FILES_PATH"/*; do
 grep -q "wayland-compatible" "$file"
 if [ $? -ne 0 ]; then
 sed -i -e 's/#exec app-name/&
 --support-wayland/g' "$file"
 fi
 done
 

The script above iterates over a set of files and checks if the wayland-compatible flag is present. If not, it attempts to add the --support-wayland option. However, this script fails when a line does not start with the #exec pattern, or if there already exists an option added in the past.

Finding the Actual Line

To solve our problem, we must first find the actual line where the application name is defined. The script should only add the Wayland options if there is no Wayland support flag already present in the file.

Fixing the grep Command

To address the first problem, we can modify the grep line in the script to:

 grep -E '^#?exec [^ ]+' "$file" | grep -q -v '--support-wayland'
 

The updated grep command uses extended regular expression with the -E flag. We begin the pattern with ^#?exec to match lines starting with #exec or just exec. We follow this pattern by a space and a list of characters that are not a space. The -v flag and --support-wayland are added in the second grep command to exclude lines that already have Wayland support added.

Updating the Specific Line

We will modify our sed command so that it adds the Wayland option right after the application name instead of blindly adding it at the end of the line with #exec.

Improving the sed Command

 sed -i -e 's/(\
 #?exec [^ ]+)/&
\
 \1 --support-wayland/' "$file"
 

The script above uses the backreference feature of sed. We group the pattern using the first set of parenthesis. When a replacement is required, \1 takes the value of the first group and is inserted before the Wayland support option.

• The initial script fails when the application name does not start with a #exec pattern and if there is a Wayland support flag already present.
• We've updated our grep command to match lines starting with just exec or with #exec, while excluding lines with present Wayland support using -v and a second grep command.
• We've improved our sed command to insert the Wayland support option right after the application name using backreferenced groups.

References

• grep man page -- Dive into all the options of grep to become a power user.
• sed man page -- Master the sed command and write more powerful scripts.
• Backreferences -- Improve your sed commands and the ways to reuse groups.